Improve #commonMenu menu #16141
Merged
Improve #commonMenu menu #16141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix siyuan-note#12506 siyuan-note#16133 使用正则 (?:get|set)Attribute\("data-name"|new Menu\((?:"|Constants) 来搜索
This was referenced Oct 17, 2025
Member
|
工作量有点大啊，辛苦了，感谢！ |
88250
approved these changes
Oct 18, 2025
Member
|
v3.3.6 |
Member
|
入口用 data-from 标识 |
Contributor
Author
|
@Vanessa219 什么情况下会出现 |
Contributor
Author
|
TCOTC
added a commit
to TCOTC/siyuan
that referenced
this pull request
Oct 20, 2025
TCOTC
added a commit
to TCOTC/siyuan
that referenced
this pull request
Oct 20, 2025
TCOTC
added a commit
to TCOTC/Whisper
that referenced
this pull request
Oct 20, 2025
TCOTC
added a commit
to TCOTC/siyuan
that referenced
this pull request
Oct 21, 2025
2 tasks
Vanessa219
pushed a commit
that referenced
this pull request
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
01
更换数据库排序菜单的文案为：
跟筛选菜单的文案形式保持一致：
02
把已有的 #commonMenu 元素的 data-name 属性值都提取到 Constants 里，方便插件使用（还需要修改 petal）。例如：
03
为一些菜单增加了 data-name 属性或 data-subname 属性，以满足插件、主题、代码片段的开发需求 #12506 。例如：
04
大纲相关菜单添加 data-name 和 data-id 属性 #16133 。例如：
05
改进点击文档块标打开菜单或属性面板：（还有另一半改进在 #16142 ）